Re: A Patch for Partially Blocked Plugin Messages in EVMSGUI

"Changju Gao" <[email protected]> Mon, 09 Apr 2007 09:18:20 -0600
Newsgroups gmane.linux.evms.devel
Message-ID <[email protected]>
Hi Luciano,

Nice to get your message. The revised patch works fine here. 
I verified that EVMSN doesn't have the problem. 

Although I like to take the credit, but Stewart Peatross, also 
from Novell, actually found this bug. 


Best regards,


- Changju Gao


>>> Luciano Chavez <[email protected]> 4/9/2007 9:03 AM >>>
On Thu, 2007-04-05 at 16:31 -0600, Changju Gao wrote:
> When starting EVMS engine, EVMSUI uses a "startup_window" 
> to display status, like "Discovering segments". In the meantime, if 
> a plugin sends back a question, EVMSGUI uses a message 
> window to display the question and wait for responses. 
> 
> However, the message window is placed behind the startup window. 
> And the message is partially blocked. Users cannot move the message
> to the front.
> 
> The message does attempt to make itself on top of the main window, 
> but the problem is that the main window doesn't exist yet. 
> 
> So I added code to make the message window a transient of the startup
> window, if the main window is not there. This essentially puts the message
> window at the very top. 
> 
> 
> Created a patch for 2.5.5 and tested on my SLES10 box. 

Hi Changju,

Thank you for the patch! You found a GUI bug that apparently has been
there a long time! I'm not sure why I never considered the case where an
alert comes in during the startup window because I am sure I saw some in
the past.

I made one slight stylistic change to your patch and so can you apply
the attached patch and verify it still works as before? If it does, I
will commit the changes to CVS.

Also, I looked at the ncurses UI code and I think it is OK but if you
haven't tried the same scenario with evmsn, can you and report if it
works as expected or not?

Thanks again!

-- 
Luciano Chavez <[email protected]>
IBM


-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Evms-devel mailing list
[email protected]
To subscribe/unsubscribe, please visit:
https://lists.sourceforge.net/lists/listinfo/evms-devel