Re: [PATCH 7/8] pxa: add frame buffer on pxa168 aspenite platform

2009/11/20 Eric Miao <[email protected]>:
>> +       int err = 0;
>> +       if (on) {
>> +               if (spi_gpio_reset != -1) {
>> +                       err = gpio_request(spi_gpio_reset, "TPO_LCD_SPI_RESET");
>> +                       if (err) {
>> +                               printk(KERN_ERR "failed to request GPIO for TPO LCD RESET\n");
>> +                               return err;
>> +                       }
>> +                       gpio_direction_output(spi_gpio_reset, 0);
>> +                       msleep(100);
>
> This is really a loooong delay, there any specific reason for such a long
> delay, I'm seeing this to slow down the boot up significantly?
>
> Otherwise looks OK to me, and I prefer the defconfig file change to
> be a separate patch please.
>

Actually, This is just an example for other real products. There is no
such spi_reset pin on Aspenite , so machine info set it spi_gpio_reset
== -1. Or do you think we should delete these lines?

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with
Crystal Reports now.  http://p.sf.net/sfu/bobj-july