drm_fb_helper: Impossible to change video mode

Paulius Zaleckas <[email protected]> Fri, 20 Nov 2009 15:16:28 +0200
Newsgroups gmane.linux.fbdev.devel,gmane.comp.video.dri.devel
Message-ID <[email protected]>
Hi,

On drivers using drm_fb_helper's in fb_ops it is not possible to change
video mode, because of different var->pixclock evaluation:

int drm_fb_helper_check_var(struct fb_var_screeninfo *var,
			    struct fb_info *info)
{
[...]
	if (var->pixclock == -1 || !var->pixclock)
		return -EINVAL;
[...]

int drm_fb_helper_set_par(struct fb_info *info)
{
[...]
	if (var->pixclock != -1) {
		DRM_ERROR("PIXEL CLCOK SET\n");
		return -EINVAL;
	}
[...]

One of these evaluations will fail regardless of pixclock value.

P.S. check CLCOK spelling :)

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with
Crystal Reports now.  http://p.sf.net/sfu/bobj-july