Re: [PATCH] cfbimgblt: Allow generic BitBLT functions to work with swapped pixel order in bytes.

On Sat, 2007-09-01 at 15:47 +0200, Pavel Pisa wrote:
> On Friday 31 August 2007 13:03, Antonino A. Daplas wrote:
> > >  May it be - this would make some not so nice effects
> > > for cursor when some strange font width is used.
> >
> > You basically have 3 choices:
> >
> > 1. Fix copyarea/fillrect
> > 2. Accept that the console may become corrupted if a non-8x16 font is
> > loaded.
> > 3. Tell the console layer that it can only handle multiple-of-8 wide
> > fonts
> 
> Hello Tony and Geert,
> 
> I have updated patch to support all above operations. The feature
> is disabled at compile time if CONFIG_FB_CFB_REV_PIXELS_IN_BYTE is not set.
> I have added simplified inline functions variants for this case
> to help compiler to optimize code. The compiler should be able to optimize
> code to same instructions as before this change. If option is enabled,
> then actual swapping is controlled by FB_NONSTD_REV_PIX_IN_B
> option in variable informations.
> 
> I have tested code on our target with fbcon=font:ProFont6x11 and 7x14
> and I see no glitches, but more precise review by more people is probably
> necessary mainly to check, that there is no regression for regular use.
> Is there some userspace tests which invoke copyarea, fillrectangles
> and blits with different parameters?

There're no userspace tools, but I'll do my own testing. I'll have your
patches go to the -mm tree soon, and if there are problems, it should be
easily noticed by users.

Thanks.

Tony



-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/