Re: cvs tree

Hello,

On Mon, 2004-10-11 at 16:29, Andre Tomt wrote:
> Andreas Gruenbacher wrote:
> > there is no public CVS tree, but I have uploaded a snapshot for you to 
> > http://acl.bestbits.at/nfsacl/2.6.9-rc2/.
> 
> There seems to be two problems with those patches, one with compiling 
> with gcc-2.95 (fix attached - this was also present in the version that 
> was posted in LKML a while back), and a used function thats not 
> exported. I havn't been able to track it down either, hence I have 
> nothing to export. The function in question is rpc_change_program, a 
> missing patch?

Yes, sunrpc-change-program-4 is missing. Sorry, i have added it.

> diff -Naur linux-2.6.9-rc4-1/net/sunrpc/xdr.c linux-2.6.9-rc4-2/net/sunrpc/xdr.c
> --- linux-2.6.9-rc4-1/net/sunrpc/xdr.c	2004-10-11 13:05:28.000000000 +0200
> +++ linux-2.6.9-rc4-2/net/sunrpc/xdr.c	2004-10-11 13:27:50.000000000 +0200
> @@ -1107,6 +1107,7 @@
>  	unsigned int copied = 0, todo, avail_here;
>  	struct page **ppages = NULL;
>  	int err = 0;
> +	unsigned int avail_page;
>  
>  	if (encode) {
>  		if (xdr_encode_word(buf, base, desc->array_len) != 0)
> @@ -1160,7 +1161,7 @@
>  		base += buf->page_base;
>  		ppages = buf->pages + (base >> PAGE_CACHE_SHIFT);
>  		base &= ~PAGE_CACHE_MASK;
> -		unsigned int avail_page = min_t(unsigned int,
> +		avail_page = min_t(unsigned int,
>  			PAGE_CACHE_SIZE - base, avail_here);
>  		c = kmap(*ppages) + base;

This patch is good as well. Compilers newer than that allow variable
definitions between statements, so this didn't fail for me.

Thanks,
-- 
Andreas Gruenbacher <[email protected]>
SUSE Labs, SUSE LINUX AG


_______________________________________________
acl-devel mailing list
[email protected]
http://acl.bestbits.at/mailman/listinfo/acl-devel