Re: [PATCH 00/12] cifs: fix string conversions from wire format to local charset (try #4)

Jeff Layton wrote:
> Fourth (and hopefully final) respin of the patchset to clean up string
> conversion from the server to local charset.

The patchset looks fine and I think these patches are merge-ready.

Acked-by: Suresh Jayaraman <[email protected]>


> The main differences from the last patchset are some minor changes
> suggested by Suresh J.:
> 
> 1) remove a redundant check for error code in cifs_from_ucs2
> 2) change the prototype of cifs_strndup to return a char pointer instead
>    of a int (and fix up the callers, of course)
> 
> Other than those changes, this set is identical to the earlier ones.
> 
> Jeff Layton (12):
>   nls: add a nls_nullsize inline
>   cifs: move #defines for mapchars into cifs_unicode.h
>   cifs: add replacement for cifs_strtoUCS_le called cifs_from_ucs2
>   cifs: add new function to get unicode string length in bytes
>   cifs: rename cifs_strlcpy_to_host and make it use new functions
>   cifs: convert CIFSTCon to use new unicode helper functions
>   cifs: fix session setup unicode string saving to use new unicode
>     helpers
>   cifs: remove cifs_readlink and CIFSSMBQueryReparseLinkInfo
>   cifs: change CIFSSMBUnixQuerySymLink to use new helpers
>   cifs: change cifs_get_name_from_search_buf to use new unicode helper
>   cifs: remove legacy NTLMSSP code
>   cifs: remove cifs_strfromUCS_le
> 
>  fs/cifs/cifs_unicode.c |  196 ++++++++-
>  fs/cifs/cifs_unicode.h |   20 +-
>  fs/cifs/cifsfs.h       |    2 -
>  fs/cifs/cifspdu.h      |   11 -
>  fs/cifs/cifsproto.h    |    5 +-
>  fs/cifs/cifssmb.c      |  224 ++--------
>  fs/cifs/connect.c      | 1152 +-----------------------------------------------
>  fs/cifs/link.c         |  114 +-----
>  fs/cifs/misc.c         |   71 ---
>  fs/cifs/readdir.c      |   26 +-
>  fs/cifs/sess.c         |   80 +---
>  include/linux/nls.h    |   19 +
>  12 files changed, 302 insertions(+), 1618 deletions(-)
> 


-- 
Suresh Jayaraman