Re: Re: [PATCH 00/12] cifs: fix string conversions from wire format to local charset (try #3)

On Thu, 2009-04-30 at 11:06 -0400, Jeff Layton wrote:
> The bottom line is that those 2 patches remove code that is just dead
> weight today. That code should never have been in the tree in the
> first
> place.
> 
> I realize that you don't agree, but quite frankly you don't have a dog
> in this fight. Those of us who have to maintain this code for
> enterprise distributions *do*. Reducing code size and complexity is
> very real concern for us. Removing dead codepaths is a huge win.
> 
> When the readlink and NTLMSSP code is ready to be re-merged, I'll be
> happy to see it, but until then it has no business being in the tree.

I strongly second this feeling.

git has history, no code is lost forever, so if it is not used it should
really, really go.
Resurrecting any dead code is a matter of a git command or 2 (easier
case a git-revert)

Simo.

-- 
Simo Sorce
Samba Team GPL Compliance Officer <[email protected]>
Principal Software Engineer at Red Hat, Inc. <[email protected]>