Re: Re: [PATCH 00/12] cifs: fix string conversions from wire format to local charset (try #3)
Suresh Jayaraman <[email protected]>
| Newsgroups | gmane.linux.file-systems.cifs |
|---|---|
| Message-ID | <[email protected]> |
Jeff Layton wrote: > On Wed, 29 Apr 2009 15:44:37 -0500 > Steve French <[email protected]> wrote: > >> I don't know whether this should go in stable or not. It is rather large >> and would have trouble merging if we went back before 2.6.29 but >> I don't object given the possible effect of an incorrect conversion >> overrun. >> > > I'm leaning against stable for this. It's a pretty big set. > > We had some earlier patches that fixed most, if not all of the places > where the destination buffer could be overrun. I consider this code > to mainly be cleanup and to ensure that we don't walk past the end of > the source buffer. Did we ensure that all the buffer overrun fixes went in for -stable? I'll do a check tommorrow, but just asking if someone has already checked that. Thanks, -- Suresh Jayaraman