Re: [PATCH] cifs: fix pointer initialization and checks in cifs_follow_symlink
Jeff Moyer <[email protected]>
| Newsgroups | gmane.linux.file-systems.cifs |
|---|---|
| Message-ID | <[email protected]> |
Jeff Layton <[email protected]> writes: > This is a respin of the patch posted yesterday. It includes a fix for > a bogus NULL pointer check that Jeff Moyer spotted. > > It's possible for CIFSSMBQueryUnixSymLink to return without setting > target_path to a valid pointer. If that happens then the current > value to which we're initializing this pointer could cause an oops > when it's kfree'd. > > CIFSSMBQueryUnixSymLink also has an incorrect NULL pointer check. > Thanks to Jeff Moyer for pointing that out. > > Reported-by: Jeff Moyer <[email protected]> > Signed-off-by: Jeff Layton <[email protected]> Reviewed-by: Jeff Moyer <[email protected]>