new regression from cifs open on lookup patches

I've run across a new regression due to the open on lookup patches when
working against a server with functioning posix open calls. Prior to
those patches, opening a directory would simply result in a
revalidation of the dir, at most this would mean a QPathInfo call would
go out on the wire.

Since the introduction of these patches, opening a directory causes an
actual open call to go out on the wire for the directory. In general,
the server will then return a status of NT_STATUS_FILE_IS_A_DIRECTORY
that gets translated to -EACCES.

The main place I've noticed this is when trying recursively remove a
directory (rm -rf). rm will openat(AT_FDCWD, ...) the dir, and then try
to walk the subdirectories. That fails. Backing out the open intent
patches fixes the problem.

This will definitely need to be fixed before 2.6.30 is released, as I'm
certain this will break more than "rm". Attaching a testcase that can
be used to test this.

-- 
Jeff Layton <[email protected]>

_______________________________________________
linux-cifs-client mailing list
[email protected]
https://lists.samba.org/mailman/listinfo/linux-cifs-client

#define _GNU_SOURCE
#include <sys/types.h>
#include <sys/stat.h>
#include <fcntl.h>
#include <stdio.h>
#include <errno.h>

int
main(int argc, char **argv)
{
	int fd;

	fd = openat(AT_FDCWD, argv[1], O_RDONLY|O_NOCTTY|O_NONBLOCK|O_NOFOLLOW);
	if (fd < 0) {
		printf("openat returned %d\n", errno);
		return 1;
	}

	printf("success\n");
	return 0;
}