Re: [PATCH 0/3] cifs: some random patches for 2.6.31
Steve French <[email protected]>
| Newsgroups | gmane.linux.file-systems.cifs |
|---|---|
| Message-ID | <[email protected]> |
On Tue, May 26, 2009 at 11:42 AM, Jeff Layton <[email protected]> wrote: > On Tue, 26 May 2009 10:08:27 -0500 > default, but 0744 (or 0755 even) would be an improvement. VFAT seems to > default to 0755, so maybe we should just go with that. No problem at all using the 0755 default, unless other users object it seems better than current default >> 3) No problem will merge very soon > Let me turn this question around. Why should /bin/mount bother > restricting user mounts to those entries in /etc/fstab if you can > easily circumvent those restrictions by calling the setuid mount helper > directly? If mount.cifs only supports user mounts through fstab, then you couldn't bypass this behavior by calling mount.cifs directly - it would still look for a matching entry in fstab. You added code to mount.cifs to check fstab ... right? I thought that you were suggesting a) turning mount.cifs to setuid by default b) forbidding all user mounts via mount.cifs unless they were explicitly permitted via fstab (I was simply suggesting that we make sure that the syntax of fstab cifs mounts is broad enough to support both use cases. -- Thanks, Steve