Re: [PATCH] cifs: remove "sockopt" mount option

This one might have been useful for specialized tuning as we once saw
with Samba, but you are right that it is currently unused

On Thu, Jun 11, 2009 at 9:22 AM, Jeff Layton<[email protected]> wrote:
> ...another dead option that was never hooked up to anything.
>
> Signed-off-by: Jeff Layton <[email protected]>
> ---
>  fs/cifs/connect.c |    6 ------
>  1 files changed, 0 insertions(+), 6 deletions(-)
>
> diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
> index 97f4311..8b8dd9f 100644
> --- a/fs/cifs/connect.c
> +++ b/fs/cifs/connect.c
> @@ -99,7 +99,6 @@ struct smb_vol {
>        bool nostrictsync:1; /* do not force expensive SMBflush on every sync */
>        unsigned int rsize;
>        unsigned int wsize;
> -       unsigned int sockopt;
>        unsigned short int port;
>        char *prepath;
>  };
> @@ -1137,11 +1136,6 @@ cifs_parse_mount_options(char *options, const char *devname,
>                                vol->wsize =
>                                        simple_strtoul(value, &value, 0);
>                        }
> -               } else if (strnicmp(data, "sockopt", 5) == 0) {
> -                       if (value && *value) {
> -                               vol->sockopt =
> -                                       simple_strtoul(value, &value, 0);
> -                       }
>                } else if (strnicmp(data, "netbiosname", 4) == 0) {
>                        if (!value || !*value || (*value == ' ')) {
>                                cFYI(1, ("invalid (empty) netbiosname"));
> --
> 1.6.0.6
>
>



-- 
Thanks,

Steve