Re: linux-next: cifs tree build failure
Steve French <[email protected]>
| Newsgroups | gmane.linux.file-systems.cifs,gmane.linux.kernel.next,gmane.linux.kernel |
|---|---|
| Message-ID | <[email protected]> |
Jeff, I just applied and reviewed your patch 5 (thus modified your patch slightly before merging). https://mail.google.com/mail/?shva=1#search/cifs_show_address/121cfb7757cb8e86 On Mon, Jun 15, 2009 at 5:46 AM, Jeff Layton<[email protected]> wrote: > On Mon, 15 Jun 2009 13:32:22 +1000 > Stephen Rothwell <[email protected]> wrote: > >> Hi Steve, >> >> Today's linux-next build (powerpc ppc64_defconfig) failed like this: >> >> fs/cifs/cifsfs.c: In function 'cifs_show_options': >> fs/cifs/cifsfs.c:357: error: implicit declaration of function 'cifs_show_address' >> >> Caused by commit 8616e0fc1e27295316f9821a883f0e9fa6f8200f ("cifs: remove >> unneeded NULL checks from cifs_show_options"). >> >> I have used the cifs tree from next-20090612 for today. > > My fault. That function gets introduced in a later patch and I had a > bogus call left in here from when I reorganized the series. This > patch should fix it and a typo that got silently fixed in a patch that > hasn't been committed yet. > > This patch should fix both. Steve F., let me know if you want me to > respin the series on top of this patch. Note that there's still a > harmless compiler warning that gets fixed in a later patch in the > series. > > Thanks, > -- > Jeff Layton <[email protected]> > -- Thanks, Steve