Re: [PATCH] cifs: Fix incorrect return code being printed in cFYI messages

I don't mind killing them, if there is a quick and easy way to catch
the function returns for all of the cifs vfs exits, but we use these
all the time for debugging, so need an alternative to catch all of the
entry/exits from the vfs to cifs.

On Thu, Jun 25, 2009 at 10:50 AM, Christoph Hellwig<[email protected]> wrote:
> On Thu, Jun 25, 2009 at 06:12:34PM +0530, Suresh Jayaraman wrote:
>>
>> FreeXid() along with freeing Xid does add a cifsFYI debug message that
>> prints rc (return code) as well. In some code paths where we set/return
>> error code after calling FreeXid(), incorrect error code is being
>> printed when cifsFYI is enabled.
>>
>> This could be misleading in few cases. For eg.
>> In cifs_open() if cifs_fill_filedata() returns a valid pointer to
>> cifsFileInfo, FreeXid() prints rc=-13 whereas 0 is actually being
>> returned. Fix this by setting rc before calling FreeXid().
>>
>> Basically convert
>
> I'd say just kill the xid crap instead of adding cumbersome workarounds
> due to the awkward way they are defined.
>
>



-- 
Thanks,

Steve