Re: Re: [PATCH] cifs: fix fh_mutex locking in cifs_reopen_file

On Sat, Jun 27, 2009 at 8:23 PM, Jeff Layton<[email protected]> wrote:
> On Sat, 2009-06-27 at 19:10 -0500, Steve French wrote:
>> Good catch .
>>
>> I have reviewed and merged into cifs-2.6.git. Merge requested for upstream.
>>
> Great. Did it fix the problems you were seeing when testing with dbench?

I doubt that this patch would affect my dbench runs because I wasn't
getting any network
reconnections (they would have logged a warning to dmesg) and the fix
is in reopen_file (which is invoked on reconnections).

I am updating and building current samba3 on a different machine (the one I
more frequently run dbench test runs on) to check on whether this is an
Ubuntu specific limit which I had not seen before (I usually run dbench with
50 rather than 60 processes).  The Samba handle limit should (and was)
be quite large.

In any case, as long as we are sure we are hitting a Samba server
limit (or server side
per-process limit), we are ok and can continue to review/merge the very large
inode patches.  I am verifying with one additional pair of temporary
stats (counters of successful opens) in the exit path of cifs_open and
cifs_close)
to make sure that those match what I have already verified that we are seeing
with smbstatus and the client side counters on number of successful posix_opens.



-- 
Thanks,

Steve