Re: [PATCH] cifs: Read buffer overflow
Steve French <[email protected]>
| Newsgroups | gmane.linux.file-systems.cifs,gmane.network.samba.internals |
|---|---|
| Message-ID | <[email protected]> |
Jeff noticed a typo in your patch (maxword -> maxwords) - I will fix and merge On Sun, Aug 2, 2009 at 6:00 AM, Roel Kluin <[email protected]> wrote: > Check whether index is within bounds before testing the element. > > Signed-off-by: Roel Kluin <[email protected]> > --- > diff --git a/fs/cifs/cifs_unicode.c b/fs/cifs/cifs_unicode.c > index 60e3c42..cfdb831 100644 > --- a/fs/cifs/cifs_unicode.c > +++ b/fs/cifs/cifs_unicode.c > @@ -44,7 +44,7 @@ cifs_ucs2_bytes(const __le16 *from, int maxbytes, > int maxwords = maxbytes / 2; > char tmp[NLS_MAX_CHARSET_SIZE]; > > - for (i = 0; from[i] && i < maxwords; i++) { > + for (i = 0; i < maxword && from[i]; i++) { > charlen = codepage->uni2char(le16_to_cpu(from[i]), tmp, > NLS_MAX_CHARSET_SIZE); > if (charlen > 0) > -- Thanks, Steve _______________________________________________ linux-cifs-client mailing list [email protected] https://lists.samba.org/mailman/listinfo/linux-cifs-client