[PATCH 0/7] cifs.upcall: fixes and improvements for SPNEGO upcalls
Jeff Layton <[email protected]>
| Newsgroups | gmane.linux.file-systems.cifs,gmane.network.samba.internals |
|---|---|
| Message-ID | <[email protected]> |
This set is a series of patches to fix several problems with cifs.upcall. There are a few behavioral changes with this set: 1) nerf the "-c" option, which was just confusing for users. It now tries to get a cifs/ principal first and then falls back to a host/ prefix if that fails. I think it's safe to assume that if a cifs/ principal exists then that's the one we'll want to use. If that's incorrect, please let me know. 2) to get the hostname for the service principal, it now reverse-resolves the IP address passed by the kernel. This makes the code much less sensitive to the hostname used when mounting. It also adds some cleanup to the code and some debug-level logging that can be used for troubleshooting problems. Review appreciated. Jeff Layton (7): cifs.upcall: clean up logging and add debug messages cifs.upcall: formatting cleanup cifs.upcall: declare a structure for holding decoded args cifs.upcall: try getting a "cifs/" principal and fall back to "host/" cifs.upcall: clean up flag handling cifs.upcall: use ip address passed by kernel to get server's hostname cifs.upcall: fix IPv6 addrs sent to upcall to have colon delimiters client/cifs.upcall.c | 319 +++++++++++++++++++++------------ docs-xml/manpages-3/cifs.upcall.8.xml | 4 +- 2 files changed, 202 insertions(+), 121 deletions(-)