Re: [PATCH 4/5] cifs: take reference to inode for oplock breaks

On Fri, Aug 21, 2009 at 10:48 AM, Jeff Layton <[email protected]> wrote:

>
> As long as you can do so in a non-racy way, then I'm not opposed to
> that long-term. The problem though is that I don't have a lot of
> confidence in the open file tracking code. It's extremely hard to
> follow and definitely has races. I don't think it's really possible to
> do what you suggest safely until the open file tracking code has been
> fixed.
>
> For now, I'm pretty sure this set should fix the problems that users
> are hitting in the oplock codepath today. I'd like to fix that first
> before we embark on a redesign of it.
>

You may be right that this should be two stages, but your 2nd and 3rd patch
are already large, so I doubt that it would grow (and might make it easier
to follow and more logical).

-- 
Thanks,

Steve

_______________________________________________
linux-cifs-client mailing list
[email protected]
https://lists.samba.org/mailman/listinfo/linux-cifs-client