Re: [PATCH] cifs: consolidate reconnect logic in smb_init routines
Steve French <[email protected]>
| Newsgroups | gmane.linux.file-systems.cifs |
|---|---|
| Message-ID | <[email protected]> |
On Thu, Sep 3, 2009 at 9:24 AM, Jeff Layton<[email protected]> wrote: > On Thu, 3 Sep 2009 09:00:35 -0500 >> > Also, I'm not sure we have the list of handle-based ops correct. What >> > about the SetFileInfo calls? >> >> Yes - I forgot to mention a related point in the earlier email. >> Are we handling checking for SMB close and SMB findclose correctly - >> do we have code in the caller that turns EAGAIN into rc = 0 >> (if the session dropped, the handle is already closed). >> >> > > Yes, that probably needs to be looked at as well. Either way though, I > suggest we shoot for no behavioral changes with the first patch and then > plan to fix what needs fixing once there aren't 2 copies of the > same code. Agreed -- Thanks, Steve