Re: [PATCH] cifs: fix locking and list handling code in cifs_open and its helper
Steve French <[email protected]>
| Newsgroups | gmane.linux.file-systems.cifs |
|---|---|
| Message-ID | <[email protected]> |
On Fri, Sep 25, 2009 at 8:53 AM, Jeff Layton <[email protected]> wrote: > The patch to remove cifs_init_private introduced a locking imbalance. It > didn't remove the leftover list addition code and the unlocking in that > function. cifs_new_fileinfo does the list addition now, so there should > be no need to do it outside of that function. > > pCifsInode will never be NULL, so we don't need to check for that. This > patch also gets rid of the ugly locking and unlocking across function > calls. > > Signed-off-by: Jeff Layton <[email protected]> > Acked-by: Steve French <[email protected]> merged -- Thanks, Steve