[PATCH] cifs: potential NULL dereference in parse_DFS_referrals()
Roel Kluin <[email protected]>
| Newsgroups | gmane.network.samba.internals,gmane.linux.file-systems.cifs |
|---|---|
| Message-ID | <[email protected]> |
allocation may fail, prevent a NULL dereference. Signed-off-by: Roel Kluin <[email protected]> --- diff --git a/fs/cifs/cifssmb.c b/fs/cifs/cifssmb.c index b195773..7ea3240 100644 --- a/fs/cifs/cifssmb.c +++ b/fs/cifs/cifssmb.c @@ -3963,6 +3963,10 @@ parse_DFS_referrals(TRANSACTION2_GET_DFS_REFER_RSP *pSMBr, GFP_KERNEL); cifsConvertToUCS((__le16 *) tmp, searchName, PATH_MAX, nls_codepage, remap); + if (tmp == NULL) { + rc = -ENOMEM; + goto parse_DFS_referrals_exit; + } node->path_consumed = cifs_ucs2_bytes(tmp, le16_to_cpu(pSMBr->PathConsumed), nls_codepage);