[patch] remove redundant check for file's private_data
Shirish Pargaonkar <[email protected]>
| Newsgroups | gmane.linux.file-systems.cifs |
|---|---|
| Message-ID | <[email protected]> |
This check is redundant, whether private_data is NULL gets verified in initiate_cifs_search already. Signed-off-by: Shirish Pargaonkar [email protected] From c1945aa4698725f8f69c3e402fee7062468075c3 Mon Sep 17 00:00:00 2001 From: Shirish Pargaonkar <[email protected]> Date: Wed, 10 Mar 2010 12:24:18 -0600 Subject: [PATCH] remove redundant check for cifs file data --- fs/cifs/readdir.c | 6 +----- 1 files changed, 1 insertions(+), 5 deletions(-) diff --git a/fs/cifs/readdir.c b/fs/cifs/readdir.c index c343b14..e8a7794 100644 --- a/fs/cifs/readdir.c +++ b/fs/cifs/readdir.c @@ -812,11 +812,7 @@ int cifs_readdir(struct file *file, void *direntry, filldir_t filldir) return rc; } } - if (file->private_data == NULL) { - rc = -EINVAL; - FreeXid(xid); - return rc; - } + cifsFile = file->private_data; if (cifsFile->srch_inf.endOfSearch) { if (cifsFile->srch_inf.emptyDir) { -- 1.6.0.2 _______________________________________________ linux-cifs-client mailing list [email protected] https://lists.samba.org/mailman/listinfo/linux-cifs-client
readdir-cleanup.patch
(application/octet-stream, 782 B)
From c1945aa4698725f8f69c3e402fee7062468075c3 Mon Sep 17 00:00:00 2001 From: Shirish Pargaonkar <[email protected]> Date: Wed, 10 Mar 2010 12:24:18 -0600 Subject: [PATCH] remove redundant check for cifs file data --- fs/cifs/readdir.c | 6 +----- 1 files changed, 1 insertions(+), 5 deletions(-) diff --git a/fs/cifs/readdir.c b/fs/cifs/readdir.c index c343b14..e8a7794 100644 --- a/fs/cifs/readdir.c +++ b/fs/cifs/readdir.c @@ -812,11 +812,7 @@ int cifs_readdir(struct file *file, void *direntry, filldir_t filldir) return rc; } } - if (file->private_data == NULL) { - rc = -EINVAL; - FreeXid(xid); - return rc; - } + cifsFile = file->private_data; if (cifsFile->srch_inf.endOfSearch) { if (cifsFile->srch_inf.emptyDir) { -- 1.6.0.2