Re: [patch] cifs: use add_to_page_cache_lru
Nick Piggin <[email protected]>
| Newsgroups | gmane.linux.file-systems,gmane.linux.file-systems.cifs |
|---|---|
| Message-ID | <20100319011310.GG25636@laptop> |
On Thu, Mar 18, 2010 at 01:43:17PM -0500, Steve French wrote: > Seems reasonable to me (also Shaggy acked this). Any idea how likely > it would affect performance (and would thus need to run through some > simple iozone and cthon (timing mode) or similar perf testing) It should positively affect LRU ordering, and CPU efficiency, but both such a tiny amount it should be in the noise. It wouldn't affect IO patterns (except as a side effect of slightly different pagecache reclaim, but again in the noise). I wouldn't worry about benchmarking it. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html