Re: [Patch] Make credentials file parameters consistent with command line parameters

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Sat, 3 Apr 2010 22:09:45 -0400
Scott Lovenberg <[email protected]> wrote:

> This patch makes the mount.cifs credentials file parameters consistent with
> the command line parameters to remove ambiguity between the command line
> parameter format and the credentials file format. That is, it parses for
> both short and long form of the 'username', 'password', and 'domain'
> parameters.  This patch is against the current cifs-utils-4.2.
> 
> I'm also thinking of adding a second patch that allows for parsing a
> "domain/user", "domain%user" and "domain/user%password" formats as allowed
> from the command line.
> 
> Comments are appreciated.

Thanks for the patch. It looks like a reasonable change but the patch
is malformed and doesn't apply. You've also sent it as a MIME encoded
attachment. The ideal way to do this is to commit your patch to a git
tree, use git-format-patch to generate the patch and git-send-email to
send it.

- -- 
Jeff Layton <[email protected]>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.14 (GNU/Linux)

iEYEARECAAYFAku4kwYACgkQyP0gxQMdzIAZxgCcDAmOOTq6FVexs8FFAKaP9VBO
VOcAmQEXykt8xbk29hR3IDp1czq9hYkN
=MgcR
-----END PGP SIGNATURE-----