Re: [patch] cifs: use add_to_page_cache_lru
Steve French <[email protected]> Tue, 20 Apr 2010 22:31:39 -0500
| Newsgroups | gmane.linux.file-systems.cifs,gmane.linux.file-systems |
|---|---|
| Message-ID | <[email protected]> |
queued up for when the merge window opens ... thx On Thu, Mar 18, 2010 at 8:13 PM, Nick Piggin <[email protected]> wrote: > On Thu, Mar 18, 2010 at 01:43:17PM -0500, Steve French wrote: >> Seems reasonable to me (also Shaggy acked this). Any idea how likely >> it would affect performance (and would thus need to run through some >> simple iozone and cthon (timing mode) or similar perf testing) > > It should positively affect LRU ordering, and CPU efficiency, but both > such a tiny amount it should be in the noise. It wouldn't affect IO > patterns (except as a side effect of slightly different pagecache > reclaim, but again in the noise). > > I wouldn't worry about benchmarking it. > > -- Thanks, Steve