Re: [PATCH 1/4] cifs: make cifs_lookup return a dentry

Jeff Layton <[email protected]> Sat, 22 May 2010 10:08:36 -0400
Newsgroups gmane.linux.file-systems,gmane.linux.file-systems.cifs
Message-ID <[email protected]>
On Sat, 22 May 2010 14:30:51 +0100
Al Viro <[email protected]> wrote:

> On Fri, May 21, 2010 at 02:25:14PM -0400, Jeff Layton wrote:
> > cifs_lookup doesn't actually return a dentry. It instantiates the one
> > that's passed in, but callers don't have any way to know if the lookup
> > succeeded.
> 
> Huh?  Of course they do - ->lookup() has every right to do just that;
> d_add() and return NULL is perfectly legitimate.

OK, bad description on my part... Is one way of doing this preferred
over another?

-- 
Jeff Layton <[email protected]>
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html