Re: [PATCH] accept all supported values for dir_mode

On Thu,  3 Jun 2010 02:39:19 -0400
Scott Lovenberg <[email protected]> wrote:

> The option parsing function now accepts all values for 'dir_mode' that are supported by the kernel side code.
> 
> Signed-off-by: Scott Lovenberg <[email protected]>
> ---
>  mount.cifs.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/mount.cifs.c b/mount.cifs.c
> index 65754c0..21ce532 100644
> --- a/mount.cifs.c
> +++ b/mount.cifs.c
> @@ -812,7 +812,7 @@ static int parse_opt_token(const char *token)
>  		return OPT_FILE_MODE;
>  	if (strncmp(token, "dmask", 5) == 0)
>  		return OPT_DMASK;
> -	if (strncmp(token, "dir_mode", 8) == 0)
> +	if (strncmp(token, "dir_mode", 4) == 0 || strncmp(token, "dirm", 4) == 0)
				      ^^^^
Sigh. But I can confirm that this is similarly broken in the kernel
so we have little choice but to live with it here.

>  		return OPT_DIR_MODE;
>  	if (strncmp(token, "nosuid", 6) == 0)
>  		return OPT_NO_SUID;


Committed...
-- 
Jeff Layton <[email protected]>