Re: 2.6.8-rc2-mm1

Adrian Bunk <[email protected]> Thu, 29 Jul 2004 16:36:06 +0200
Newsgroups gmane.linux.kernel,gmane.linux.file-systems.jffs
Message-ID <[email protected]>
The following issue comes from Linus' tree:

JFFS2_COMPRESSION_OPTIONS is asked even if JFFS2_FS support isn't 
selected.

The patch below adds a dependency on JFFS2_FS to 
JFFS2_COMPRESSION_OPTIONS.

I've also added a dependency on EXPERIMENTAL which seemed to be logical 
after reading the description of this option (but even if you disagree 
with this, please add the dependency on JFFS2_FS).


Signed-off-by: Adrian Bunk <[email protected]>

--- linux-2.6.8-pre2-mm1/fs/Kconfig.old	2004-07-29 16:24:35.000000000 +0200
+++ linux-2.6.8-pre2-mm1/fs/Kconfig	2004-07-29 16:24:55.000000000 +0200
@@ -1088,18 +1088,19 @@
 	  including a link to the mailing list where details of the remaining
 	  work to be completed for NAND flash support can be found, see the 
 	  JFFS2 web site at <http://sources.redhat.com/jffs2>.
 
 	  Say 'N' unless you have NAND flash and you are willing to test and
 	  develop JFFS2 support for it.
 
 config JFFS2_COMPRESSION_OPTIONS
 	bool "Advanced compression options for JFFS2"
+	depends on JFFS2_FS && EXPERIMENTAL
 	default n
 	help
 	  Enabling this option allows you to explicitly choose which
 	  compression modules, if any, are enabled in JFFS2. Removing
 	  compressors and mean you cannot read existing file systems,
 	  and enabling experimental compressors can mean that you
 	  write a file system which cannot be read by a standard kernel.
 
 	  If unsure, you should _definitely_ say 'N'.