Re: [PATCH] Reduce nr of ptr derefs in fs/jffs2/summary.c

Jan Engelhardt <[email protected]> Fri, 16 Dec 2005 23:05:08 +0100 (MET)
Newsgroups gmane.linux.kernel,gmane.linux.file-systems.jffs
Message-ID <[email protected]>
>> >Benefits:
>> > - micro speed optimization due to fewer pointer derefs
>> > - generated code is slightly smaller
>> 
>> Should not these two at best be done by the compiler?
>
>[...]
>But a human *can* make the obvious leap and tell the compiler that the
>value can be computed once and then saved.  And besides, isn't the code
>just *much* nicer to look at, above?

The third point Jesper mentioned was about readability, but I never 
questioned that.


Jan Engelhardt
--