Re: unused fs/jffs2/acl.c:jffs2_clear_acl()
KaiGai Kohei <[email protected]> Thu, 29 Jun 2006 23:27:32 +0900
| Newsgroups | gmane.linux.kernel,gmane.linux.file-systems.jffs |
|---|---|
| Message-ID | <[email protected]> |
David Woodhouse wrote: > On Thu, 2006-06-29 at 15:01 +0200, Adrian Bunk wrote: > >>it might not have been intended that jffs2_clear_acl() in Linus' tree >>is unused? > > > I suspect you're right -- thanks for pointing it out. > > Kaigai-san? I'm sorry, it's a serious BUG. When an inode is cleared, jffs2_clear_acl() should be called to release on-memory ACL. Because the current implementation didn't care about this cleaning-up, we have memory-leaking. Please wait a patch for a while. Thanks, -- KaiGai Kohei <[email protected]>