Re: [PATCH] fs: Memory allocation cleanups

Frederik Deweerdt <[email protected]> Fri, 21 Jul 2006 16:37:23 +0200

Newsgroups	gmane.linux.kernel,gmane.linux.file-systems.jffs
Message-ID	<20060721143723.GB2772@slug>

On Fri, Jul 21, 2006 at 01:50:55PM +0200, [email protected] wrote:
> -		dnotify_req = (struct dir_notify_req *) kmalloc(
> -						sizeof(struct dir_notify_req),
> +		dnotify_req = kmalloc(sizeof(struct dir_notify_req),
>  						 GFP_KERNEL);
						^^^^^ 
Should be aligned with the kmalloc?
> -	ext_acl = (reiserfs_acl_header *) kmalloc(sizeof(reiserfs_acl_header) +
> -						  acl->a_count *
> +	ext_acl = kmalloc(sizeof(reiserfs_acl_header) + acl->a_count *
>  						  sizeof(reiserfs_acl_entry),
>  						  GFP_NOFS);
						^^^^^
This should be aligned too, I think.

Regards,
Frederik