Re: [fuse-devel] [PATCH 01/25] VFS: move attr_kill logic from notify_change into helper function
Trond Myklebust <[email protected]> Mon, 06 Aug 2007 15:04:23 -0400
| Newsgroups | gmane.comp.file-systems.reiserfs.general,gmane.linux.kernel,gmane.linux.file-systems,gmane.comp.file-systems.coda.general,gmane.linux.cluster.redhat.cluster.devel,gmane.comp.file-systems.fuse.devel,gmane.linux.file-systems.jffs,gmane.linux.uml.user,gmane.comp.file-systems.ext4,gmane.linux.file-systems.cifs,gmane.comp.file-systems.ocfs2.devel |
|---|---|
| Message-ID | <1186427063.6616.59.camel@localhost> |
On Mon, 2007-08-06 at 20:28 +0200, Miklos Szeredi wrote: > Your patch is changing the API in a very unsafe way, since there will > be no error or warning on an unconverted fs. And that could lead to > security holes. > > If we would rename the setattr method to setattr_new as well as > changing it's behavior, that would be fine. But I guess we do not > want to do that. Which "unconverted fses"? If we're talking out of tree stuff, then too bad: it is _their_ responsibility to keep up with kernel changes. Trond - To unsubscribe from this list: send the line "unsubscribe reiserfs-devel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html