Re: [PATCH 3/3] fs/namei.c: fix coding style in atomic_open() and lookup_open()

On Fri, Jul 31, 2026 at 11:20:04AM +0200, Jori Koolstra wrote:
> 
> > Op 31-07-2026 10:36 CEST schreef Christian Brauner <[email protected]>:
> > 
> >  
> > Commit 4886c80eef20 ("vfs: call audit_inode_child() in lookup_open() on
> > failure") indented a continuation line with spaces, left three
> > declarations without a following blank line and used a trailing */ on the
> > last line of a block comment.  Clean all of that up, no functional change.
> > 
> > Fixes: 4886c80eef20 ("vfs: call audit_inode_child() in lookup_open() on failure")
> > Signed-off-by: Christian Brauner (Amutable) <[email protected]>
> > 
> 
> I know checkpatch complains about this, but since namei.c has a bit of its own
> style, I didn't pay too much attention to that. Do we adhere strictly to
> checkpatch style in VFS? Anyhow, I'll add new lines after declarations in the

We don't care about checkpatch per se but we do leave newlines after
declarations. I think that's just pretty standard all around afaict.