Re: [PATCH 2/9] selftests/exec: let binfmt_flag_supported() return a bool
Farid Zakaria <[email protected]>
| Newsgroups | gmane.linux.file-systems,gmane.linux.kernel.mm,gmane.linux.kernel.bpf |
|---|---|
| Message-ID | <178571387899.1880415.16506772757157668104.b4-review@b4> |
On Thu, 30 Jul 2026 15:34:04 +0200, Christian Brauner <[email protected]> wrote: > binfmt_flag_supported() returns 0 when the flag is supported and -1 > when it is not, so every caller reads backwards: > > if (binfmt_flag_supported('T')) > SKIP(return, "kernel without the 'T' flag"); > > Make it return a bool and flip the callers. errno from a failed probe > is still set for callers that check it. > > [...] Reviewed-by: Farid Zakaria <[email protected]> -- Farid Zakaria <[email protected]>