Re: [PATCH] f2fs: use the mount idmap for the owner check in f2fs_xattr_advise_set()
Rochan Avlur <[email protected]>
| Newsgroups | gmane.linux.file-systems.f2fs,gmane.linux.kernel,gmane.linux.kernel.stable,gmane.linux.file-systems |
|---|---|
| Message-ID | <CALbtPkWdgFcrJLqPRfqVOsNgkSSB7H9+NhegeBqfU6LfdyF7Mg@mail.gmail.com> |
Hi Chao,
> > f2fs_xattr_advise_set() calls inode_owner_or_capable() with
> > &nop_mnt_idmap before allowing the advise xattr to be set, instead of
> > the idmap that was passed into the handler.
> >
> > Since f2fs supports idmapped mounts, this compares the caller's fsuid
> > against the unmapped on-disk owner rather than the mapped owner; resulting
> > in the actual owner to be wrongly denied with -EPERM. Use the idmap
> > argument that was already passed to the xattr handler instead.
> >
> > Fixes: 984fc4e76d63 ("f2fs: support idmapped mounts")
> > Cc: [email protected]
> > Signed-off-by: Rochan Avlur <[email protected]>
>
> Thanks for the patch.
>
> I notice there is already a patch:
>
> https://lore.kernel.org/linux-f2fs-devel/[email protected]
Thanks for pointing that out. I wasn't aware of Zhan's patch when I
submitted mine. Happy to defer to the earlier submission.