Re: [PATCH v8 12/15] filemap: Remove checks in mapping_set_folio_order_range()

Matthew Wilcox <[email protected]> Wed, 5 Aug 2026 04:28:50 +0100
Newsgroups gmane.linux.file-systems,gmane.linux.kernel.mm
Message-ID <[email protected]>
On Tue, Aug 04, 2026 at 05:23:27PM -0400, Gregory Price wrote:
> On Fri, Jul 31, 2026 at 09:07:57PM +0100, Matthew Wilcox (Oracle) wrote:
> >   *
> > + * hugetlb calls this with orders larger than MAX_PAGECACHE_ORDER.
> > + * Normal filesystems should not do this.
> 
> Any static way to enforce this?

Not easily.  We could look at mapping->a_ops and compare them to
hugetlbfs_aops, but this seems like overkill?  For such a low-level
interface with so few callers, I think the level of protection we had
earlier was just too much.

> Otherwise
> 
> Reviewed-by: Gregory Price (Meta) <[email protected]>
>