Re: [PATCH] fs: remove stale inode_insert5() kernel-doc parameter

On Wed 05-08-26 10:41:49, Yichong Chen wrote:
> inode_insert5() no longer has an isnew argument, but its
> kernel-doc still documents one. This triggers a W=1 kernel-doc
> warning.
> 
> Remove the stale parameter description.
> 
> Signed-off-by: Yichong Chen <[email protected]>

Looks good. Feel free to add:

Reviewed-by: Jan Kara <[email protected]>

								Honza

> ---
>  fs/inode.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/fs/inode.c b/fs/inode.c
> index a31aa7cb47f6..ed7c8df1bfca 100644
> --- a/fs/inode.c
> +++ b/fs/inode.c
> @@ -1282,7 +1282,6 @@ EXPORT_SYMBOL(unlock_two_nondirectories);
>   * @test:	callback used for comparisons between inodes
>   * @set:	callback used to initialize a new struct inode
>   * @data:	opaque data pointer to pass to @test and @set
> - * @isnew:	pointer to a bool which will indicate whether I_NEW is set
>   *
>   * Search for the inode specified by @hashval and @data in the inode cache,
>   * and if present return it with an increased reference count. This is a
> -- 
> 2.51.0
> 
-- 
Jan Kara <[email protected]>
SUSE Labs, CR