Re: [users] LIBDVDREAD UPDATE REMOVED UDFFINDFILE PATCH BREAKS RPMFORGE PACKAGE

I read the ogle post and appreciate your catching the issue, pulling in 
Ralf and  notifying the developer.  From the post however it appears 
(and please correct me if I'm wrong) that UDFFindFile at one point in 
time was exported.  Programs were written to use that function, then 
the decision was made for some reason not to export it.  The 
functionality has not yet been replaced. As stated from the post you 
directed me to (listed below between the <snip>s) a solution was 
suggested which doesn't work in all cases.  Then the maintainer states 
he's thinking of adding another function to provide some of the 
functionality of UDFFindFile.  Since it appears libdvdread is in some 
kind of indecisive state where functions are being added and removed, I 
don't think it is unreasonable to re-apply the patch until the dust 
settles. <snip>
I took a quick look at dvdbackup. From what I can see it only uses
UDFFindFile to get the sizes (in bytes) from the VIDEO_TS.*, VTS_* files.
This can be done by using DVDOpenFile, DVDFileSize, DVDCloseFile.
DVDFileSize returns the size in blocks. To get size in bytes just multiply
blocks with DVD_VIDEO_LB_LEN (2048).
This will work for all files except VTS_XX_?.VOB

I'm thinking of adding a DVD_VOB_Sizes() which will return the sizes of
all VIDEO_XX_?.VOB parts.
But I'll probably wait until after this release before making any more API
changes.
<snip>

Quoting Matthias Saou 
<thias@spam.spam.spam.spam.spam.spam.spam.egg.and.spam.freshrpms.net>:

> Gerald B. Cox wrote :
>
>> The latest version of libdvdread removed a patch which is required to
>> successfully run the dvdbackup package in the rpmforge repository.
>>
>> Can this patch be re-applied?  Or, if not, shouldn't you just go ahead
>> and delete the dvdbackup package since this action effectively breaks
>> it?
>
> I removed that patch because it is wrong. Why was dvdbackup ever 
> written to require it in the first place? I don't know, but it should 
> be fixed in dvdbackup, not worked around with an ugly hack in 
> libdvdread. For more details :
>
> http://lists.berlios.de/pipermail/ogle-devel/2005-September/000671.html
>
> Feel free to submit a patch to be included in the dvdbackup package :-D
>
> Matthias
>
> --
> Clean custom Red Hat Linux rpm packages : http://freshrpms.net/
> Fedora Core release 4 (Stentz) - Linux kernel 2.6.13-1.1532_FC4
> Load :
0.19 0.87 0.68
>