Re: A small fix for chkrootkit's .SPEC file

On Thursday 02 February 2006 19:55, Dean Takemori wrote:
> > Dean Takemori wrote:
> > > --- chkrootkit.spec-orig        2006-02-01 01:26:43.000000000 -1000
> > > +++ chkrootkit.spec     2006-02-01 21:51:20.000000000 -1000
> > > @@ -27,6 +27,7 @@
> > > BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root
> > >
> > > Requires: binutils
> > > +BuildRequires: desktop-file-utils
> >
> > For chkrootkit? That doesn't make any sense to me, especially when
> > reading the info in the desktop-file-utils rpm.
> >
> > | .desktop files are used to describe an application for inclusion in
> > | GNOME or KDE menus.  This package contains desktop-file-validate
> >
> > which
> >
> > | checks whether a .desktop file complies with the specification at
> > | http://www.freedesktop.org/standards/, and desktop-file-install
> > | which installs a desktop file to the standard directory, optionally
> > | fixing it up in the process.
> >
> > How does that fit into the *build* process of chkrootkit? How does
> > this
> > package relate to chkrootkit anyway?
>
> Read the specfile:
>
> %if %{?_without_freedesktop:1}0
>          %{__install} -Dp -m0644 chkrootkit.desktop %{buildroot}%
> {_datadir}/gnome/apps/Utilities/chkr
> ootkit.desktop
> %else
>          %{__install} -d -m0755 %{buildroot}%{_datadir}/applications/
>          desktop-file-install --vendor %{desktop_vendor}    \
>                  --add-category X-Red-Hat-Base              \
>                  --dir %{buildroot}%{_datadir}/applications \
>                  chkrootkit.desktop
> %endif
>
> I suppose, strictly speaking the patch should be something like
> (pseudocode here, I don't know
> .SPEC very well):
>
> if not (without_freedesktop)
>     BuildRequires: desktop-file-utils
> endif

Thanks for the info!
The currently used syntax is:
%{!?_without_freedesktop:BuildRequires: desktop-file-utils}
just like for example in
http://svn.rpmforge.net/svn/trunk/rpms/stellarium/stellarium.spec

kind regards,
Dries
-- 
Rpm packages for Red Hat Enterprise Linux, Fedora Core and Aurora at 
http://dries.ulyssis.org/rpm/