Re: [PATCH v3 2/5] selinux-policy-2.eclass: respect the sanctity of -rN for EAPI=8

>>>>> On Tue, 07 Apr 2026, Rahul Sandhu wrote:
 
> +if [[ ${EAPI} = 7 ]]; then
> +	# @ECLASS_VARIABLE: BASEPOL
> +	# @DESCRIPTION:
> +	# This variable contains the version string of the selinux-base-policy package
> +	# that this module build depends on. It is used to patch with the appropriate
> +	# patch bundle(s) that are part of selinux-base-policy.
> +	: "${BASEPOL:="${PVR}"}"
> +else
> +	# @ECLASS_VARIABLE: BASEPOL
> +	# @DESCRIPTION:
> +	# This variable contains the version string of the selinux-base-policy package
> +	# that this module build depends on. It is used to patch with the appropriate
> +	# patch bundle(s) that are part of selinux-base-policy.
> +	# _pN corresponds to -rN in the patch bundle(s).
> +	: "${BASEPOL:="${PV/_p/-r}"}"
> +fi
 
This won't work. eclass-to-manpage expects eclass documentation to be
left-aligned. Anything that is indented will be ignored.

You also cannot have a conditional there, i.e. if both comments were
without indentation then eclass-to-manpage would see a duplicate
definition and would terminate with an error.

-----BEGIN PGP SIGNATURE-----

iQFfBAEBCABJFiEEtDnZ1O9xIP68rzDbUYgzUIhBXi4FAmnUxegbFIAAAAAABAAO
bWFudTIsMi41KzEuMTIsMiwyDxx1bG1AZ2VudG9vLm9yZwAKCRBRiDNQiEFeLpAP
CACk0hNSz3SgvDcouiw1VnTm1/h/wGyd5LVvyd1Aii5032rJ8rBVv+pds/T7TU0j
y0jhJPsWHSISk/0xUpem4e/bK8e4btiCYvd8O1MDTDTK9N308Y539aMR8HrlQe1b
zjPASHD8z4dfIArCXFHgrZyVlz3jOSs0tE1Du4nD73527KN7KvQdmIQH+Dxknqej
PO+efmwe0WhTFPtXr1FUI3HgUCiDu39/47z5ERl04y+oHhYtYWmsWxtmb2/FY26c
OiD5CGgY9/s088E1rV+jSFC2MR1HIv5Jg5WEJ6H5NhYgyi+GaORBBp5Nw0a7I9Sd
WHUCULlT5S0YbY3das+GIsmk
=dJ7H
-----END PGP SIGNATURE-----