Re: [PATCH v3 2/5] selinux-policy-2.eclass: respect the sanctity of -rN for EAPI=8

Kenton Groombridge <[email protected]> writes:

> On 26/04/07 08:26AM, Rahul Sandhu wrote:
>> +# @ECLASS_VARIABLE: _SELINUX_POLICY_UPSTREAM_PV
>> +# @INTERNAL
>> +# @DESCRIPTION:
>> +# Internal variable representing (spoofed) upstream refpolicy version.
>> +_SELINUX_POLICY_UPSTREAM_PV=$(ver_cut 1-2)
>> +
>
> We aren't really spoofing the upstream versioning (even though it really
> doesn't mean anything). The Gentoo policy is updated in tandem with
> refpolicy, but only when refpolicy cuts a new release do the Gentoo
> policy packages use the new version, but it is admittedly by name only.
>
> Anyways, I think we can reword this to "[...] representing upstream base
> branch" or just drop the "(spoofed)" here so future readers don't get
> the wrong idea.

I agree that spoofed might scare people here. It is spoofed in an
internal sense here, but I think saying it will do more harm than good.

-----BEGIN PGP SIGNATURE-----

iQEBBAEWCgCpFiEEJaa7iN2bdkxrVUHCc4QJ9SDfkZAFAmnV4j0bFIAAAAAABAAO
bWFudTIsMi41KzEuMTIsMiwyXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25z
Lm9wZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQyNUE2QkI4OEREOUI3NjRDNkI1NTQx
QzI3Mzg0MDlGNTIwREY5MTkwDxxzYW1AZ2VudG9vLm9yZwAKCRBzhAn1IN+RkCDl
AP4w3vhPq/CE+rUG7fmM9b2CXe7Zcm5+m8AZyru+DHPdBwD/TTPM2pVkQRVn3Idv
Gp3WJIj2OVOplkJUoxPYFSSggQE=
=gjdm
-----END PGP SIGNATURE-----