Re: [PATCH v2 1/5] rpm.eclass: rework app-arch/rpm support into pre-inherit variable

Eli Schwartz <[email protected]> writes:

> app-arch/rpm supports various compression types, but usually via USE
> flags. We need ugly strings|grep to see which one is needed. rpm2targz
> dynamically detects `@system` set tools which is why it has worked
> forever.
>
> To solve this we add RPM_COMPRESS_TYPE="" before inheriting the eclass,
> which controls if app-arch/rpm is used. While testing this it also turns
> out legacy lzma, i.e. PayloadIsLzma rather than PayloadIsXz, is not
> supported by rpm2targz at all (despite bug 321439 implying it *was*
> added? the one instance I found in-tree fails). So, exclude it in such
> cases.
>
> The eclass now has effectively a "mandatory for proper support" eclass
> pre-inherit variable which nothing ever set before. Emit an eqawarn if
> it is being "held wrong", to encourage people to set this variable.
>
> Closes: https://bugs.gentoo.org/973073
> Closes: https://bugs.gentoo.org/971578
> Bug: https://bugs.gentoo.org/971600
> Bug: https://bugs.gentoo.org/321439
> Signed-off-by: Eli Schwartz <[email protected]>
> ---
>
> v2:
>
> big rework of BDEPEND generation. The first version of this patch, never
> posted, didn't include legacy lzma handling to split xz/lzma. I added it
> at the last minute and broke >= dependencies on rpm, erasing
> app-arch/rpm if it didn't work, etc. All this logic needed to be
> reverted and reintegrated.
>
> Apologies for submitting a rushed patch and never checking the results.
> I saw the other competing proposal and said "I  better submit quickly".
> :(
>
>  eclass/rpm.eclass | 101 +++++++++++++++++++++++++++++++++++++++++-----
>  1 file changed, 90 insertions(+), 11 deletions(-)
>
> [...]

LGTM. Thanks.

sam

-----BEGIN PGP SIGNATURE-----

iQEBBAEWCgCpFiEEJaa7iN2bdkxrVUHCc4QJ9SDfkZAFAmnpclEbFIAAAAAABAAO
bWFudTIsMi41KzEuMTIsMiwyXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25z
Lm9wZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQyNUE2QkI4OEREOUI3NjRDNkI1NTQx
QzI3Mzg0MDlGNTIwREY5MTkwDxxzYW1AZ2VudG9vLm9yZwAKCRBzhAn1IN+RkPKo
AQDj6kTKTM4Mclu5YbfJMxtLGmnWWs3xsjajRMcCCkIRJAEAtcc37APIbSNG8K4m
273zhGQ/JJTyr4dGlkq7gp37WgI=
=rarK
-----END PGP SIGNATURE-----