[PATCH 4/6] ecm.eclass: Avoid unused BUILD_QCH CMake warnings

Andreas Sturmlechner <[email protected]> Sat, 06 Jun 2026 00:58:34 +0200

Newsgroups	gmane.linux.gentoo.devel
Message-ID	<[email protected]>

... especially on PIM packages ported to ECMGenerateQDoc meanwhile.

Signed-off-by: Andreas Sturmlechner <[email protected]>
---
 eclass/ecm.eclass | 19 +++++++++++++++----
 1 file changed, 15 insertions(+), 4 deletions(-)

diff --git a/eclass/ecm.eclass b/eclass/ecm.eclass
index ad042e3545a2..1580322237b3 100644
--- a/eclass/ecm.eclass
+++ b/eclass/ecm.eclass
@@ -303,6 +303,17 @@ _ecm_handbook_optional() {
 	fi
 }
 
+# @FUNCTION: _ecm_buildqch_optional
+# @DESCRIPTION:
+# Used with ECM_QTHELP; ticks -DBUILD_QCH only if available.
+_ecm_buildqch_optional() {
+	if use doc; then
+		echo "-DBUILD_QCH=ON"
+	elif grep -Eq "option.*BUILD_QCH" CMakeLists.txt; then
+		echo "-DBUILD_QCH=OFF"
+	fi
+}
+
 # @FUNCTION: _ecm_strip_handbook_translations
 # @INTERNAL
 # @DESCRIPTION:
@@ -564,6 +575,10 @@ ecm_src_configure() {
 		cmakeargs+=( $(_ecm_handbook_optional) )
 	fi
 
+	if [[ ${ECM_QTHELP} = true ]]; then
+		cmakeargs+=( $(_ecm_buildqch_optional) )
+	fi
+
 	if in_iuse designer && [[ ${ECM_DESIGNERPLUGIN} = true ]]; then
 		cmakeargs+=( -DBUILD_DESIGNERPLUGIN=$(usex designer) )
 	fi
@@ -572,10 +587,6 @@ ecm_src_configure() {
 		cmakeargs+=( -DBUILD_PYTHON_BINDINGS=OFF )
 	fi
 
-	if [[ ${ECM_QTHELP} = true ]]; then
-		cmakeargs+=( -DBUILD_QCH=$(usex doc) )
-	fi
-
 	# Common ECM configure parameters (invariants)
 	local ecm_config=${BUILD_DIR}/gentoo_ecm_config.cmake
 	cat > ${ecm_config} <<- _EOF_ || die
-- 
2.54.0

signature.asc (application/pgp-signature, 829 B)