Re: [PATCH 5/6] selinux-policy-2.eclass: prefix all internal vars with _SELINUX_POLICY_

Sam James <[email protected]> Sat, 20 Jun 2026 22:11:34 +0100

Newsgroups	gmane.linux.gentoo.devel
Organization	Gentoo
Message-ID	<[email protected]>

Rahul Sandhu <[email protected]> writes:

> Signed-off-by: Rahul Sandhu <[email protected]>
> ---
>  eclass/selinux-policy-2.eclass | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/eclass/selinux-policy-2.eclass b/eclass/selinux-policy-2.eclass
> index c597f19c210a..911ef39781e1 100644
> --- a/eclass/selinux-policy-2.eclass
> +++ b/eclass/selinux-policy-2.eclass
> @@ -120,17 +120,17 @@ S="${WORKDIR}"
>  # Modules should always depend on at least the first release of the
>  # selinux-base-policy for which they are generated.
>  if [[ -n ${BASEPOL} ]]; then
> -	_BASE_POLICY_VERSION="${BASEPOL}"
> +	_SELINUX_POLICY_BASE_POLICY_VERSION="${BASEPOL}"
>  else
> -	_BASE_POLICY_VERSION="${_SELINUX_POLICY_UPSTREAM_PV}"
> +	_SELINUX_POLICY_BASE_POLICY_VERSION="${_SELINUX_POLICY_UPSTREAM_PV}"

Having repeated _POLICY is a bit unfortunate but I also tend to like
having the prefix be the eclass name.


>  fi
>  
>  RDEPEND="
>  	>=sys-apps/policycoreutils-2.5
> -	>=sec-policy/selinux-base-policy-${_BASE_POLICY_VERSION}[${SELINUX_POLICY_USEDEP}]
> +	>=sec-policy/selinux-base-policy-${_SELINUX_POLICY_BASE_POLICY_VERSION}[${SELINUX_POLICY_USEDEP}]
>  "
>  
> -unset _BASE_POLICY_VERSION
> +unset _SELINUX_POLICY_BASE_POLICY_VERSION
>  
>  DEPEND="${RDEPEND}"
>  BDEPEND="

signature.asc (application/pgp-signature, 418 B)