Re: [PATCH 1/3] shell-completion.eclass: include functions of bash-completion-r1.eclass

Michał Górny <[email protected]> Mon, 22 Jun 2026 20:49:11 +0200

Newsgroups	gmane.linux.gentoo.devel
Organization	Gentoo
Message-ID	<[email protected]>

On Mon, 2026-06-22 at 19:43 +0200, Florian Schmaus wrote:
> Include the functions of bash-completion-r1.eclass instead of
> inheriting bash-completion-r1.eclass. The idea is to phase out
> bash-completion-r1.eclass in favor of shell-completion.eclass with
> EAPI 9.
> 

I agree with the goal but not with the implementation.  I don't think
it's a good idea to keep two copies of the functions around.  I'd rather
have them in one of the eclasses, with some special var used in the
other to get them around to the other one.

-- 
Best regards,
Michał Górny

signature.asc (application/pgp-signature, 293 B)