Re: [PATCH 1/6] acct-user.eclass: Automatically add deps based on ACCT_USER_HOME_OWNER

On Tue, Jun 23, 2026 at 11:35:55AM -0400, Michael Orlitzky wrote:
> On 2026-06-23 14:18:37, James Le Cuirot wrote:
> > 
> > You seem to be saying that ACCT_USER_HOME_OWNER shouldn't go away entirely, and
> > therefore the fix still makes sense? I think your argument makes sense, but I'd
> > never heard of ACCT_USER_HOME_OWNER before I hit this issue, so I think someone
> > else should decide what to do.
> > 
> 
> There may be extreme cases where it is useful, but with only
> 
>   $ grep -rl ACCT_USER_HOME_OWNER acct-user | wc -l
>   14
> 
> examples (half of which are obvious mistakes), I guess I am hoping
> that we could review them first. If they're all bugs, then we don't
> need to add code to the eclass that would make future bugs easier.

I had a look at some cases, and it's a mixed bag. qmail.eclass is setting
ownership on directories within the HOME, but not on the HOME itself, as far as
I can see. anacron calls `diropts -o root -g cron` followed by `keepdir` on the
HOME. monkeysphere doesn't appear to set any ownership at all.

While cases like monkeysphere could be handled outside of acct-user, qmail and
cron have multiple consumers, so handling ownership within acct-user seems like
a good thing, as long as it's not done anywhere else.

On that basis, I think ACCT_USER_HOME_OWNER should stay, and I will merge the
fix now, but I am happy to go with whatever the eclass maintainers eventually
decide.