Re: [PATCH 1/9] esplit.eclass: add new eclass

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Ulrich M=C3=BCller <[email protected]> writes:

>>>>>> On Thu, 09 Jul 2026, Sam James wrote:
>
>> +# }
>> +#
>> +# process_list
>
> Add a blank line here, to separate the comment block from the following
> unrelated code?

OK.

>
>> +case ${EAPI} in
>> +	8|9) ;;
>> +	*) die "${ECLASS}: EAPI ${EAPI:-0} not supported" ;;
>> +esac
>> +
>> +if [[ -z ${_ESPLIT_ECLASS} ]] ; then
>> +_ESPLIT_ECLASS=3D1
>
> For such a simple eclass, the inherit guard may add more overhead than
> it can potentially prevent. Maybe omit it? We have precendent with other
> simple eclasses.

OK.

>
>> +	local -
>
> The "-" argument was introduced in Bash 4.4, so using it in EAPI 8 is
> fine (it wouldn't be in EAPI 7).

Ah, right.

>
> Ulrich

thanks,
sam

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEBBAEWCgCpFiEEJaa7iN2bdkxrVUHCc4QJ9SDfkZAFAmpQ0ycbFIAAAAAABAAO
bWFudTIsMi41KzEuMTIsMiwyXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25z
Lm9wZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQyNUE2QkI4OEREOUI3NjRDNkI1NTQx
QzI3Mzg0MDlGNTIwREY5MTkwDxxzYW1AZ2VudG9vLm9yZwAKCRBzhAn1IN+RkCzR
AP0REu37Z10wYiiVeynn90cpdAj/3Dn/BLeBHMoIyzWwLgEA95OfYj8y4sAiWcIf
2n6BMK5o/RPllqRw5jTh5rTQWg0=
=lkH2
-----END PGP SIGNATURE-----
--=-=-=--