Re: [PATCH 6/9] kernel-2.eclass: port to esplit.eclass

Sam James <[email protected]> Fri, 10 Jul 2026 12:36:29 +0100
Newsgroups gmane.linux.gentoo.devel
Organization Gentoo
Message-ID <[email protected]>
--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Ulrich M=C3=BCller <[email protected]> writes:

>>>>>> On Fri, 10 Jul 2026, Sam James wrote:
>
>>>> --- a/eclass/kernel-2.eclass
>>>> +++ b/eclass/kernel-2.eclass
>>>> @@ -792,7 +792,7 @@ universal_unpack() {
>>>> debug-print "Inside universal_unpack"
>>>>=20
>>>> local OKV_ARRAY
>>>> -	local IFS=3D.; OKV_ARRAY=3D(${OKV}); unset IFS
>>>> +	mapfile -d '' OKV_ARRAY < <(IFS=3D. esplit "${OKV}")
>>>=20
>>> TBH, I find the replacement code harder to understand than the original.
>>> (Probably it is also less efficient?)
>
>> I could go either way in this instance, tbh. No real stake in it other
>> than needing the violation gone.
>
> But mpagano has already fixed it for kernel-2.eclass? What am I missing
> here?

I was converting everything to use the same idiom.

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEBBAEWCgCpFiEEJaa7iN2bdkxrVUHCc4QJ9SDfkZAFAmpQ2T0bFIAAAAAABAAO
bWFudTIsMi41KzEuMTIsMiwyXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25z
Lm9wZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQyNUE2QkI4OEREOUI3NjRDNkI1NTQx
QzI3Mzg0MDlGNTIwREY5MTkwDxxzYW1AZ2VudG9vLm9yZwAKCRBzhAn1IN+RkHgT
AQCokxbaiBpzJcY27xQZHmIqKJktktJzJfTT8pSaYOgSsQEAkLZH6+WlBw55fmJE
gwGqDRzBxNCVmGg9sahKwMGmwwE=
=hva1
-----END PGP SIGNATURE-----
--=-=-=--