Re: RFC: PostgreSQL Documentation

David Abbott <[email protected]> Sat, 23 Jul 2011 15:56:18 -0400
Newsgroups gmane.linux.gentoo.documentation
Message-ID <CACs9S6ZmUNQdJiTqjhturU=e4UD0XZA2OSKXJh505yUaHPamSA@mail.gmail.com>
On Sat, Jul 23, 2011 at 3:44 PM, David Abbott <[email protected]> wrote:
> On Fri, Jul 22, 2011 at 8:57 AM, Aaron W. Swenson <[email protected]> wrote:
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA256
>>
>> I think the documentation I've written[1] for PostgreSQL is pretty well
>> set to be published. I'm submitting it here for a final review.
>>
> Also This section;
> <p>
> You can change your locale and encoding selections at database creation time
> (<uri
> link="http://www.postgresql.org/docs/current/static/sql-createdatabase.html"><c>CREATE
> DATABASE</c></uri>). In order to change the locale for a database after you have
> created it, you must drop the database and start over again.
> </p>
> The c tags can't be inside the uri tag;
>
> postgresql.xml:410: element uri: validity error : Element c is not
> declared in uri list of possible children
> DATABASE</c></uri>). In order to change the locale for a database after you have
>
> I would change it so it reads a little clearer to somethin like;
>
> <p>
> You can change your locale and encoding selections at database <uri
>  link="http://www.postgresql.org/docs/current/static/sql-createdatabase.html">creation
>  time.</uri>). In order to change the locale for a database after you have
> created it, you must drop the database and start over again.
> </p>
I forgot to remove the ). after </uri>

I would also remove this section;
</body>
</section>
<section>
<title>Initialize</title>
<body>

<p>
To finish the installation:
</p>

I attached a diff from yours to the changes I made.
Regards,
David
-- 
David Abbott (dabbott)
Gentoo
http://dev.gentoo.org/~dabbott/
postgresql.xml.diff (text/plain, 1.3 KB)
--- postgresql.old.xml	2011-07-23 15:50:41.000000000 -0400
+++ postgresql.xml	2011-07-23 15:45:22.000000000 -0400
@@ -404,21 +404,10 @@
 </p>
 
 <p>
-You can change your locale and encoding selections at database creation time
-(<uri
-link="http://www.postgresql.org/docs/current/static/sql-createdatabase.html"><c>CREATE
-DATABASE</c></uri>). In order to change the locale for a database after you have
-created it, you must drop the database and start over again.
-</p>
-
-</body>
-</section>
-<section>
-<title>Initialize</title>
-<body>
-
-<p>
-To finish the installation:
+You can change your locale and encoding selections at database <uri
+  link="http://www.postgresql.org/docs/current/static/sql-createdatabase.html">creation
+  time.</uri> In order to change the locale for a database after you have
+created it, you must drop the database and start over again.  
 </p>
 
 <pre caption="Finalize the installation">
@@ -625,7 +614,7 @@
 
 <p>
 At this point you are ready to continue on with the official <uri
-src="http://www.postgresql.org/docs/current/static/tutorial.html">PostgreSQL
+link="http://www.postgresql.org/docs/current/static/tutorial.html">PostgreSQL
 Tutorial</uri>. The tutorial will guide you through creating roles, databases,
 schemata and all that fun and useful stuff.
 </p>