Re: virtualbox /proc/modules warning

В Сб, 14/09/2013 в 00:46 +0300, Alex Efros пишет:
> On Sat, Sep 14, 2013 at 12:16:20AM +0400, Peter Volkov wrote:
> > That said I don't think it's worth to have such patch in portage
>  > tree - just apply it locally.
> 
> Why is that? How such patch may harm anything?
> 
> --- /opt/VirtualBox/VBox.sh.old	2013-09-14 00:45:13.873137602 +0300
> +++ /opt/VirtualBox/VBox.sh	2013-09-14 00:45:17.553137565 +0300
> @@ -32,7 +32,7 @@
...
> -elif ! lsmod|grep -q vboxdrv; then
> +elif [ -r /proc/modules ] && ! lsmod|grep -q vboxdrv; then

If /proc/modules is unreadable we don't know if modules are loaded or
not. In such case it's better to show warning. That said, problem with
this check is that it should check for functionality virtualbox requires
(with /dev/vboxdrv) but such change should go upstream.

--
Peter.